[SPARK-44718][SQL] Match ColumnVector memory-mode config default to OffHeapMemoryMode config value #42394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majdyz
changed the title
HyukjinKwon
reviewed
Aug 9, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Aug 11, 2023
|
The failing CIs seems to be unrelated test failures. |
cloud-fan
reviewed
Aug 15, 2023
| import org.apache.spark.sql.internal.SQLConf | ||
| import org.apache.spark.sql.test.SharedSparkSession | ||
|
|
||
| class ConfigColumnVectorModeDefaultSuite extends SharedSparkSession { |
There was a problem hiding this comment.
it's probably too much to add a new test suite for it. We have tests for the config framework and .fallbackConf is already tested by ConfigEntrySuite. Shall we just remove it?
cloud-fan
approved these changes
Aug 15, 2023
|
The failure is unrelated, I'm merging it to master, thanks! |
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…ffHeapMemoryMode config value ### What changes were proposed in this pull request? Set the column vector default memory mode to depend on the off-heap memory mode flag. This is to prevent a user from using Vectorized-Reader with an on-heap column-vector by default when the off-heap memory mode is enabled on the cluster. ### Why are the changes needed? Avoid the unintentional usage of on-heap memory in vectorized-reader when off-heap memory mode is enabled by the user. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual & existing tests. Closes apache#42394 from majdyz/offheap-colvec-mode-default-value. Lead-authored-by: Zamil Majdy <[email protected]> Co-authored-by: Zamil Majdy <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…ffHeapMemoryMode config value ### What changes were proposed in this pull request? Set the column vector default memory mode to depend on the off-heap memory mode flag. This is to prevent a user from using Vectorized-Reader with an on-heap column-vector by default when the off-heap memory mode is enabled on the cluster. ### Why are the changes needed? Avoid the unintentional usage of on-heap memory in vectorized-reader when off-heap memory mode is enabled by the user. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual & existing tests. Closes apache#42394 from majdyz/offheap-colvec-mode-default-value. Lead-authored-by: Zamil Majdy <[email protected]> Co-authored-by: Zamil Majdy <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Mrhs121
pushed a commit
to Mrhs121/spark
that referenced
this pull request
Apr 17, 2024
…ffHeapMemoryMode config value ### What changes were proposed in this pull request? Set the column vector default memory mode to depend on the off-heap memory mode flag. This is to prevent a user from using Vectorized-Reader with an on-heap column-vector by default when the off-heap memory mode is enabled on the cluster. ### Why are the changes needed? Avoid the unintentional usage of on-heap memory in vectorized-reader when off-heap memory mode is enabled by the user. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual & existing tests. Closes apache#42394 from majdyz/offheap-colvec-mode-default-value. Lead-authored-by: Zamil Majdy <[email protected]> Co-authored-by: Zamil Majdy <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit afcccb4)
yaooqinn
added a commit
that referenced
this pull request
Jul 2, 2024
…lumnVector.offheap.enabled's doc field ### What changes were proposed in this pull request? Followup of #42394 ``` * - spark.sql.columnVector.offheap.enabled - When true, use OffHeapColumnVector in ColumnarBatch. Defaults to ConfigEntry(key=spark.memory.offHeap.enabled, defaultValue=false, doc=If true, Spark will attempt to use off-heap memory for certain operations. If off-heap memory use is enabled, then spark.memory.offHeap.size must be positive., public=true, version=1.6.0). - <value of spark.memory.offHeap.enabled> - 2.3.0 ``` The doc field shall be interpolated by MEMORY_OFFHEAP_ENABLED.key instead of MEMORY_OFFHEAP_ENABLED. In this PR, we remove the doc redundant doc as it's also can be found in the `MEMORY_OFFHEAP_ENABLED.defaultValueString` ### Why are the changes needed? docfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manually debugging ### Was this patch authored or co-authored using generative AI tooling? no Closes #47165 from yaooqinn/minor2. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…lumnVector.offheap.enabled's doc field ### What changes were proposed in this pull request? Followup of apache#42394 ``` * - spark.sql.columnVector.offheap.enabled - When true, use OffHeapColumnVector in ColumnarBatch. Defaults to ConfigEntry(key=spark.memory.offHeap.enabled, defaultValue=false, doc=If true, Spark will attempt to use off-heap memory for certain operations. If off-heap memory use is enabled, then spark.memory.offHeap.size must be positive., public=true, version=1.6.0). - <value of spark.memory.offHeap.enabled> - 2.3.0 ``` The doc field shall be interpolated by MEMORY_OFFHEAP_ENABLED.key instead of MEMORY_OFFHEAP_ENABLED. In this PR, we remove the doc redundant doc as it's also can be found in the `MEMORY_OFFHEAP_ENABLED.defaultValueString` ### Why are the changes needed? docfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manually debugging ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47165 from yaooqinn/minor2. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set the column vector default memory mode to depend on the off-heap memory mode flag. This is to prevent a user from using Vectorized-Reader with an on-heap column-vector by default when the off-heap memory mode is enabled on the cluster.
Why are the changes needed?
Avoid the unintentional usage of on-heap memory in vectorized-reader when off-heap memory mode is enabled by the user.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual & existing tests.